Skip to content

CryptoSwift version updated #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ivopintodasilva
Copy link

This fixed the Carthage build for Xcode 9.

@kylef
Copy link
Owner

kylef commented Sep 19, 2017

@ivopintodasilva You change has no effect on Xcode. The Package.swift file is for the Swift Package Manager and is not related to Carthage. This code change is in the branch of the dependencies for non Apple platforms. Any Xcode project generated by swift will be using the other branch of dependencies. Am I missing something? Did you test your change?

#if os(macOS) || os(iOS) || os(watchOS) || os(tvOS)
...
#else
....Package(url: "https://github.com/krzyzanowskim/CryptoSwift.git", majorVersion: 0, minor: 7)
#endif

@krzyzanowskim
Copy link

or even more strict

Package(url: "https://github.com/krzyzanowskim/CryptoSwift.git", "0.7.2")

@jonblatho
Copy link
Contributor

CryptoSwift is now at version 0.8.0 and this package, which supports Swift 4 only on the master branch, continues to refer to version 0.6.9, which was released in April, before Swift 4.

The fact that the pull requester’s comment was less than relevant to the purpose of this change doesn’t change the fact that this package has not compiled on Linux for months because of the outdated CryptoSwift dependency and the version bump remains very necessary.

@jonblatho jonblatho mentioned this pull request Dec 19, 2017
@kylef kylef closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants